8000 feat(ci): upgrades ci to run tests using python 3 by fzipi · Pull Request #1934 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(ci): upgrades ci to run tests using python 3 #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

feat(ci): upgrades ci to run tests using python 3 #1934

merged 1 commit into from
Mar 24, 2021

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Nov 19, 2020 •
edited
Loading

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

This PR upgrades ftw to 1.2.3, which has py3 support.

@fzipi fzipi requested a review from fgsch November 19, 2020 13:05
fgsch
fgsch approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor
@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fgsch
Copy link
Contributor
fgsch commented Nov 19, 2020

Thank you!

This is p ending the ftw release (should happen in the next few hours).

@fzipi fzipi mentioned this pull request Nov 19, 2020
Closed
@fzipi fzipi added the 🚀 enhancement New feature or request label Nov 19, 2020
fgsch
fgsch reviewed Nov 20, 2020
View reviewed changes
@fzipi fzipi force-pushed the v3.4/dev-ftw-py3-tests branch 2 times, most recently from fed5a5c to e192ea3 Compare November 26, 2020 17:50
@franbuehler franbuehler mentioned this pull request Dec 5, 2020
Closed
@dune73 dune73 mentioned this pull request Jan 4, 2021
Closed
@dune73
Copy link
Member
dune73 commented Jan 4, 2021

@fzipi : This has some tests failing. Otherwise it would be good to go, would not it?

And are the failing tests failing because of the changes to FTW?

@fzipi
Copy link
Member Author
fzipi commented Jan 4, 2021

@dune73 Yes, this is becauseof the changes regarding the py3 full support. Some things are handled differently by py2 and py3, in particular string vs. bytes and encoding.

With @fgsch were in the mix for getting a proper version but it might be a breaking change for some users (might be). So we cannot merge this one yet.

@dune73
Cop 8000 y link
Member
dune73 commented Jan 4, 2021

OK. So this is pending for the time being. Thank you.

@dune73 dune73 mentioned this pull request Jan 27, 2021
Closed
@dune73
Copy link
Member
dune73 commented Feb 1, 2021

Any update on this front @fzipi and @fgsch?

@dune73 dune73 mentioned this pull request Mar 1, 2021
Closed
@fzipi fzipi force-pushed the v3.4/dev-ftw-py3-tests branch from e192ea3 to 9ae4d17 Compare March 2, 2021 17:30
@fzipi fzipi changed the title feat(ci): upgrades ftw to python 3 supported version feat(ci): upgrades ci to run tests using python 3 Mar 2, 2021
@fzipi fzipi mentioned this pull request Mar 2, 2021
Closed
@fzipi fzipi force-pushed the v3.4/dev-ftw-py3-tests branch from 63bb325 to 015751d Compare March 15, 2021 14:26
@fzipi fzipi force-pushed the v3.4/dev-ftw-py3-tests branch from 015751d to 6981a59 Compare March 23, 2021 12:36
@fzipi
Copy link
Member Author
fzipi commented Mar 23, 2021

Looks like python 3.9 fails with the 1.2.3 version, but 3.8 works. Will then fix the pipeline run to 3.8 for now.

@fzipi
fix(ci): upgrade ftw tests to be run using py3
88837ca 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>

Update Python to 3.x as the working version.
@fzipi fzipi force-pushed the v3.4/dev-ftw-py3-tests branch from 6981a59 to 88837ca Compare March 24, 2021 21:45
@dune73
Copy link
Member
dune73 commented Mar 24, 2021

Great work @fzipi. Thank you very much.

fgsch
fgsch approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor
@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@fzipi
Copy link
Member Author
fzipi commented Mar 24, 2021

Finally, it is working. We might want to merge! @dune73

@fzipi fzipi merged commit 2ec881c into coreruleset:v3.4/dev Mar 24, 2021
@fzipi fzipi deleted the v3.4/dev-ftw-py3-tests branch March 24, 2021 22:02
@dune73 dune73 mentioned this pull request Apr 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsch fgsch fgsch approved these changes

Assignees
No one assigned
Labels
🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fzipi @fgsch @dune73
0