Moved --> keyword from 941180 (PL1) into new stricter sibling rule 941181 (PL2) #2060 #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 19, 2021 14:31
…h is matched by stricter sibling 941181
|
This is great. Thank you very much @53cur3M3 for this fix. Namely the tests. Nitpicking
Proposal 941180: |
|
941181-3 is putting payload in parameter name |
|
True that. Thanks. Could you add the comments mentioned above? Good to merge afterwards, I think. |
|
Thank you for this PR. I spotted a small problem: in line 735, This should be |
|
LGTM. |
|
Congratulations on the first merged PL @53cur3M3. 🍻 |
RubieV
added a commit
to RubieV/coreruleset
that referenced
this pull request
Jun 17, 2022
This improvement adds further consistency to coreruleset#2088 The PL1 rule (`941180`) of Node-Validator keywords contains both evident attack fragments, i.e. `document.cookie`, as well as comment payloads, i.e. `<!--`. This change moves all comment payloads to the PL2 rule (`941181`) that already contains the comment closing tag `-->`. This makes the PL1 rule in line with the goal of PL1, and makes the already existing PL2 rule consistent with the goal of having `comment` payloads.
theseion
pushed a commit
to RubieV/coreruleset
that referenced
this pull request
Feb 26, 2023
This improvement adds further consistency to coreruleset#2088 The PL1 rule (`941180`) of Node-Validator keywords contains both evident attack fragments, i.e. `document.cookie`, as well as comment payloads, i.e. `<!--`. This change moves all comment payloads to the PL2 rule (`941181`) that already contains the comment closing tag `-->`. This makes the PL1 rule in line with the goal of PL1, and makes the already existing PL2 rule consistent with the goal of having `comment` payloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved --> keyword from 941180 (PL1) into new stricter sibling rule 941181 (PL2) #2060
Updated 941180 to include a negative test for -->
Added tests for 941181
Replaces PR2082