Improve sampling efficiency2 #2094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Maybe @airween can test modsec 3 compatiblity? 😄 |
|
We need somebody to test this for ModSec3. If these tests pass, the conflict with 901 has to be resolved, afterwards, we are ready to merge. Tests for ModSec3:
|
|
Meeting decision June (#2074 (comment)): |
|
Hey @theMiddleBlue did you have time to test this on ModSec3? If yes, we would like to merge this. Ideally before the chat on Monday. |
|
Nevermind. I fired up my nginx and tested this on ModSec3. Works like a charm. No further testing necessary. |
|
I resolved the conflict in 901 and the PR is ready to be merged now. Thank you for the cleanup @53cur3M3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify sampling rules, and improve efficiency, as per : #2091
Tested in apache modsec2, but requires testing in modsec3 to validate leading zeros are handled gracefully; and preferably also what happens if TX.sampling_rnd100 is undefined