942220: fix magic number #2010
942220: fix magic number #2010
Conversation
|
Hmm, looks like I messed up creating the test, but it looks good to me, can anyone see what's wrong? |
| @@ -423,7 +426,7 @@ SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAME | |||
| # This rule has two stricter sibling: 942361 and 942362. | |||
| # The keywords 'alter' and 'union' led to false positives. | |||
| # Therefore they have been moved to PL2 and the keywords have been extended on PL1. | |||
| # The original version also had loose word boundaries and context checksm cause further false positives. | |||
| # The original version also had loose word boundaries and context checksm cause further false positives. | |||
There was a problem hiding this comment.
| # The original version also had loose word boundaries and context checksm cause further false positives. | |
| # The original version also had loose word boundaries and context checksum cause further false positives. |
Just as a clean code move, it may as well be spelt correctly. Unless it was done purposefully for line length reasons?
AFAICT the numbers don't match. 2.2250738585072007e-308 (rule) vs 2.2250738585072011e-308 (test) |
|
Ah, you're right. I found the https://www.exploringbinary.com/php-hangs-on-numeric-value-2-2250738585072011e-308/ |
|
Thank you for the quick fix. Merging now. |
Revert the PHP magic number back to the correct version as reported in #2009.