Remove Rule 910110 #2148
Merged
Remove Rule 910110 #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a worthwhile cleanup. Thank you @53cur3M3. Opinions? |
I think we should keep this rule - as I see there is not other similar rule, I mean where the user can activate its own deny list as simply way. IMHO. |
|
You have a point there. But if we want that, is not there a better way than leaving dead code as an artifact of inspiration? I'd see a plugin doing this job based on a backlist that actually works. |
|
As we discussed on last monthly chat, this PR can be merged, and we will make a plugin to solve the allow/deny list issues. Looks good to me. |
|
Thank you for the PR @53cur3M3. Merging now ahead of the meeting tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old rule 910110 which has been commented out a long time.
Spider labs web honeypots thought to be no longer running.