8000 Fixing phpMyAdmin FPs by azurit · Pull Request #2172 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing phpMyAdmin FPs #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2021
Merged

Fixing phpMyAdmin FPs #2172

merged 2 commits into from
Sep 18, 2021

Conversation

azurit
Copy link
Member
@azurit azurit commented Aug 5, 2021 •
edited
Loading
  • fixed 2 real-world FPs
  • fixed ruleRemoveTargetById ordering in rule 9008110 (based on removed IDs)
  • adding new rule (was triggering for example for information_schema DB)

@dune73
Copy link
Member
dune73 commented Sep 2, 2021

Thank you for this PR @azurit. Let's review this and get it merged. Taking it to the meeting on Monday.

@dune73 dune73 mentioned this pull request Sep 2, 2021
Closed
@dune73 dune73 requested a review from lifeforms September 9, 2021 09:01
@dune73
Copy link
Member
dune73 commented Sep 9, 2021

Decisions from the August project meeting: @lifeforms will review and merge this.

@lifeforms
Copy link
Member

LGTM!

@lifeforms lifeforms merged commit cf565f0 into coreruleset:v3.4/dev Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifeforms lifeforms Awaiting requested review from lifeforms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azurit @dune73 @lifeforms
0