Update version strings to 3.4.0-dev #2100
Conversation
For the development branch, use "x.y.z-dev" notation. Change made automatically in all rule files using: python3 -m pip install --user --upgrade msc_pyparser cd util/change-version ./change-version.py "../../rules/*.conf" ../../rules/ "OWASP_CRS/3.4.0-dev" "3.4.0-dev" Also, the version number in crs-setup.conf.example (rule 900990) was updated manually.
|
Looks like the comment version still contains the old version here. May be you should run the script this way to be sure: This will change the all occurrence of comment versions. |
Done using: ./change-version.py "../../rules/*.conf.example" ../../rules/ "OWASP_CRS/3.4.0-dev" "3.4.0-dev" ./change-version.py "../../crs-setup.conf.example" ../../ "OWASP_CRS/3.4.0-dev" "3.4.0-dev"
|
Thank you for spotting this! I've now also ran: |
| pass,\ | ||
| t:none,\ | ||
| setvar:tx.crs_setup_version=330" | ||
| "id:900990,\ |
There was a problem hiding this comment.
Haha, msc_pyparser have set the indent :)
| @@ -129,7 +129,7 @@ SecRule REQUEST_LINE "!@rx ^(?i:(?:[a-z]{3,10}\s+(?:\w{3,7}?://[\w\-\./]*(?::\d+ | |||
| # The regex in the following enabled rule is not supported by non-PCRE | |||
| # regular expression engines (?<!re). | |||
| # | |||
| SecRule FILES_NAMES|FILES "@rx (?<!&(?:[aAoOuUyY]uml)|&(?:[aAeEiIoOuU]circ)|&(?:[eEiIoOuUyY]acute)|&(?:[aAeEiIoOuU]grave)|&(?:[cC]cedil)|&(?:[aAnNoO]tilde)|&(?:amp)|&(?:apos));|['\"=]" \ | |||
There was a problem hiding this comment.
Hmm... here was also an extra space
|
When I made the tool, I was thinking about how we change the version string? I mean the script would expect the old and the new versions too, and replace the But now I see were some newer version string (eg. The pleasant side-effect of the tool is it formats the rule set. I mean it sets the "correct" indentation (see here our "reference"). Note, that there is an example in Btw: LGTM. |
For the development branch, use "x.y.z-dev" notation.
Change made automatically in all rule files using Airween's cool tool from #2085:
Also, the version number in crs-setup.conf.example (rule 900990) was updated manually.