8000 feat(ftw): initial go-ftw running version by fzipi · Pull Request #2120 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(ftw): initial go-ftw running version #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Jun 7, 2021

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

This PR runs go-ftw in a new test. It should not be required to pass before merge, while we test it works properly.

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
Copy link
Member Author
fzipi commented Jun 7, 2021

If you take a look at the timings, go-ftw runs in one pass in less than 1/7th of the time!

@dune73
Copy link
Member
dune73 commented Jul 2, 2021

Let's not linger too long with this additional test set. It's not a deal for the time being and the best testing we can do is using it in production. Merging now.

Thank you very much for your contribution, @fzipi. This is a new era!

@dune73 dune73 merged commit a2746db into coreruleset:v3.4/dev Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0