8000 Added new util script to find the longest data lenght in tests by airween · Pull Request #2277 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added new util script to find the longest data lenght in tests #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2021

Conversation

airween
Copy link
Contributor
@airween airween commented Oct 29, 2021

This script helps to find the longest data length in test cases. We can set it for the tests in tests/docker-compose.yaml and crs-setup.conf, in rule 900005.

@dune73
Copy link
Member
dune73 commented Nov 1, 2021

It sure is nice to be able to use msc_pyparser so swiftly. Thank you.

Would you mind adding support for --help? I do not mind if it only brings a link to the extensive README online, but I think a script has to explain itself at least a weeny bit.

@franbuehler franbuehler self-assigned this Nov 1, 2021
@airween
Copy link
Contributor Author
airween commented Nov 1, 2021

Help added. I realized that we need an optional argument: if we are looking for the longest length payload between the test cases, because we want to add a test which exceeds that, then next time we must to ignore that test. So I introduced the -i or --ignoretests optional argument, where we can list the test id's, what we want to skip. For more info, see the README or the help.

@franbuehler
Copy link
Contributor

I tested the script and it works! Looks good to me.

@fzipi
Copy link
Member
fzipi commented Nov 26, 2021

Merging, thanks!

@fzipi fzipi merged commit b55ab0f into coreruleset:v3.4/dev Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None ye 46E5 t
Development

Successfully merging this pull request may close these issues.

4 participants
0