Update send-payload-pls.sh #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also changed the default unique-ID regex to a generic selector and not one bound to a specific log format. But that's OK, I think this default is better. A wee bit uneasy about the order of characters in the enhanced regex character class, (-> prefix vs suffix), but that's probably only me. |
|
Results of a quick poll on the slack channel of the project: Strong preference for putting @spartantri, would you mind reflecting that in your PR? |
Moved _- towards the end of regex
|
Meeting decision December: @dune73 will take this one. |
|
OK. Looks good. The script is really usable now. Thank you @spartantri Can still be optimized and extended, maybe adding a sandbox option and what not. But good the way it is. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing parameter in script instructions and the regex modified to allow
-and_characters on unique id field.