8000 phpBB: Fixing FP and package deactivation by azurit · Pull Request #2299 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

phpBB: Fixing FP and package deactivation #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2022
Merged

phpBB: Fixing FP and package deactivation #2299

merged 3 commits into from
Jan 9, 2022

Conversation

azurit
Copy link
Member
@azurit azurit commented Nov 9, 2021 •
edited
Loading
  • Fixing one FP (unfortunately don't know which section of phpBB triggered it).
  • Adding rules skipping in phase 4

@azurit azurit changed the title Fixing FP and moving all rules into phase 1 phpBB: Fixing FP and moving all rules into phase 1 Nov 9, 2021
@azurit azurit changed the title phpBB: Fixing FP and moving all rules into phase 1 phpBB: Fixing FP and moving all rules into correct phase Nov 16, 2021
@azurit azurit changed the title phpBB: Fixing FP and moving all rules into correct phase phpBB: Fixing FP and package deactivation Nov 16, 2021
@dune73
Copy link
Member
dune73 commented Dec 6, 2021

Thank you. This looks good to me.

@dune73 dune73 mentioned this pull request Dec 6, 2021
Closed
@lifeforms lifeforms self-assigned this Dec 6, 2021
@franbuehler
Copy link
Contributor

Meeting decision December: @lifeforms will review this PR.

@dune73 dune73 mentioned this pull request Jan 3, 2022
Closed
@lifeforms
Copy link
Member

Looking good. Well spotted to add the phase 4 skip!

@lifeforms lifeforms merged commit 6cabdbb into coreruleset:v3.4/dev Jan 9, 2022
@fzipi fzipi mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lifeforms lifeforms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@azurit @dune73 @franbuehler @lifeforms
0