Don't cook hex escapes #2215
Merged
Don't cook hex escapes #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theseion Awesome work here! |
|
Quoting @theseion : basically, the change is:
That's all there is to review. The rest is part or the other PR |
|
Meeting decision Oct 4: @franbuehler will review this. |
Added usage section to README
4407c62 to
0b2743d
Compare
|
@franbuehler I've cherry picked the changes on top of v3.4/dev, so reviewing this PR should now be straight forward. |
franbuehler
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2210 .
This will be mergeable after #2149 has been merged.