8000 fix(ci): remove tag before releasing by fzipi · Pull Request #2231 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ci): remove tag before releasing #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2021
Merged

fix(ci): remove tag before releasing #2231

merged 2 commits into from
Oct 17, 2021

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Oct 15, 2021

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

Our new nightly releases are not updating the tag shown (but the zip file is properly generated). Using a previous step removing the tag is the recommended action.

@fzipi
fix(ci): remove tag before releasing
07174bd 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
theseion
theseion reviewed Oct 17, 2021
View reviewed changes
Copy link
Contributor
@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've suggested a change to the name of the step to make it more clear what its intention is.

@fzipi @theseion
Update .github/workflows/nightly.yml
cf9ebb7 
Co-authored-by: Max Leske <th3s3ion@gmail.com>
@fzipi fzipi merged commit 396653e into coreruleset:v3.4/dev Oct 17, 2021
@fzipi fzipi deleted the fix-release-tagging-nightly branch October 17, 2021 13:06
@dune73 dune73 mentioned this pull request Nov 1, 2021