8000 re2: use compatible syntax in rule 953120 by fzipi · Pull Request #2356 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

re2: use compatible syntax in rule 953120 #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2022
Merged

re2: use compatible syntax in rule 953120 #2356

merged 2 commits into from
Feb 5, 2022

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Jan 20, 2022

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

Remove pcre2 only syntax.

Fixes #2354

@fzipi fzipi requested a review from lifeforms January 20, 2022 21:59
@fzipi fzipi marked this pull request as ready for review January 20, 2022 22:00
@fzipi fzipi force-pushed the re2-support-953120 branch 2 times, most recently from 92ef321 to 35dd214 Compare January 21, 2022 17:19
@fzipi fzipi requested a review from fgsch January 21, 2022 17:21
@fzipi
Copy link
Member Author
fzipi commented Jan 21, 2022

Got a working test after we merge #2359 .

@fgsch
Copy link
Contributor
fgsch commented Jan 21, 2022

We might want to put this live somewhere to check for FPs but looks good to me.

@fzipi
Copy link
Member Author
fzipi commented Jan 21, 2022

Definitely. Maybe @theMiddleBlue can take a look at these also, or make it live somewhere.

@theMiddleBlue
Copy link
Contributor

Hey! If you want I can bring up an apache backend on the sandbox based on this PR :) so we can test it directly on our sandbox

@fzipi
Copy link
Member Author
fzipi commented Jan 25, 2022

This can only be tested after we merge #2359 .

fgsch
fgsch approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor
@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fzipi added 2 commits January 26, 2022 09:23
@fzipi
re2: use compatible syntax in rule 953120
5ff0910 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi
test: add tests to 953120 rule
cfcb753 
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the re2-support-953120 branch from 35dd214 to cfcb753 Compare January 26, 2022 12:27
@fzipi
Copy link
Member Author
fzipi commented Jan 26, 2022

Added tests, now this can be merged.

@fzipi
Copy link
Member Author
fzipi commented Jan 26, 2022

@lifeforms Any comment here, or just merge?

@fzipi
Copy link
Member Author
fzipi commented Feb 5, 2022

Merging then.

@fzipi fzipi merged commit 8a6ed59 into coreruleset:v3.4/dev Feb 5, 2022
@fzipi fzipi deleted the re2-support-953120 branch February 5, 2022 12:32
@fzipi fzipi mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsch fgsch fgsch approved these changes

@lifeforms lifeforms Awaiting requested review from lifeforms

Assignees
No one assigned
Labels
🏁 ready to merge ⏲️ In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rethink/rewrite rule 953120 for re2 support
3 participants
@fzipi @fgsch @theMiddleBlue
0