8000 Added additional tests for 920120 by theseion · Pull Request #2369 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added additional tests for 920120 #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

theseion
Copy link
Contributor
@theseion theseion commented Feb 5, 2022

Related to #2360

This is PR 1 of 4 that replace #2360.

@theseion theseion requested review from fgsch and fzipi February 5, 2022 08:21
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than comment, looks good. After changing ping me so it is ready to go.

Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@theseion theseion merged commit d01d19c into coreruleset:v3.4/dev Feb 5, 2022
@theseion
Copy link
Contributor Author
theseion commented Feb 5, 2022

I don't think we need a second review here, it's a simple change. Merging now.

@theseion theseion deleted the remove-negative-look-behind-add-tests-for-920120 branch February 5, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0