Backslashes 941330 #2375
Merged
Backslashes 941330 #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
\\\\backslash representation from the regular expression in rule 941330.This rule will now also work correctly in Nginx, which it didn't before (due to the
\\\\issue with Nginx), and the tests for this rule work correctly against the Nginx CRS container.Note: The backslash pattern is already covered by test 941330-1, hence a new test is not required in this instance.
This is part of ongoing issue #2332.
Suggestion to Review/Test
If someone could double-check the amendments to the regex, and maybe test that the modified rule catches the payloads expected?