8000 fix: add missing escaping backslash by theseion · Pull Request #2739 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add missing escaping backslash #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

theseion
Copy link
Contributor
@theseion theseion commented Aug 8, 2022

No description provided.

regexp-assemble data file for 933160 is missing an escaping backslash
before a double quote. This backslash is necessary because prefixes and
suffixes aren't actually processec by Regexp::Assemble, which would
force escape the double quote.
@theseion theseion added the 🐛 bug Something isn't working label Aug 8, 2022
@theseion theseion changed the title Fix 933160 fix: add missing escaping backslash Aug 8, 2022
@RedXanadu RedXanadu self-requested a review August 8, 2022 21:41
Copy link
Member
@RedXanadu RedXanadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Looks good.

@theseion theseion merged commit 9456daf into coreruleset:v4.0/dev Aug 9, 2022
@theseion theseion deleted the fix-933160 branch August 9, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0