Fixes 932130 tests urls #2880
Merged
Fixes 932130 tests urls #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Similar to #2168, I found that tests from
932130-12to932130-16have theuriparameter that does not start with a path like/. Looking at rule932130and relative tests, seems to me that the missing path is not related to what the tests are intended for (command injections inside URI parameters).All the affected tests are true tests, and, with this fix, they are correctly detected by Coraza running on a simple Go-http server.
Setting PR Draft status because I wish to test it against other servers, but I guess that they would also fail against
nginxandEnvoy.