8000 chore: Update tests to match changes in go-ftw by theseion · Pull Request #3166 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Update tests to match changes in go-ftw #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2023
Merged

chore: Update tests to match changes in go-ftw #3166

merged 1 commit into from
Mar 19, 2023

Conversation

theseion
Copy link
Contributor

No description provided.

@theseion theseion requested a review from fzipi March 18, 2023 16:46
fzipi
fzipi reviewed Mar 18, 2023
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still fail?

@theseion
Copy link
Contributor Author

Actually, those failures were unrelated. It's a race condition: coreruleset/go-ftw#141.

@fzipi fzipi merged commit fc769ea into coreruleset:v4.0/dev Mar 19, 2023
@fzipi fzipi mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @fzipi
0