fix: PHP errors data file #3119
Conversation
- moving few patterns into new file - removing whitespace from the beginning of few patterns as it's trimmer by modsec anyway
|
Thank you. +1 on the trimming away of the whitespace prefix that really does not add much. I am wondering if it is worth to add a new rule to avoid some FPs, but it's true that the FPs are quite obvious. One option would be to simply forget about the signatures - just how important are they really, namely the "The function" has an extended variant - but if we assume they are important, than I think an additional PL2 rule is warranted. Calling in the dev channel to see if we can get more opinions. |
I agree with this. Anyway, there are lots of error messages and i wasn't able to check them all. I'm sure there will be more FPs so the list of error messages for PL2 will be rising. |
|
Sounds good to me. If you think that there will be more messages to add to the PL2 list then it's probably worth it. I also agree that the whitespace doesn't add additional context. @azurit, did you mean that |
|
@theseion Yes, from the docs: |
|
I confirm that behaviour. |
|
Time to merge than. Thank you @azurit. |
Some of the patterns in
php-errors.dataare too common to be in PL1 so i'm moving them into PL2. I also removed a whitespace from the beginning of few patters as it's trimmer by modsec anyway.