docs: Rewrite issue templates for false positives and false negatives #3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
Co-authored-by: Max Leske <th3s3ion@gmail.com>
theseion
approved these changes
Feb 22, 2023
|
@RedXanadu Are you OK with this wording? If yes, please merge. |
|
Sorry for the delay in reviewing this… @dune73 This looks good! The expanded guidance is clearer. One comment I would make, from a Dev on Duty perspective: if someone is reporting an FP then logs are a "must have", while a curl call is only a "nice to have". It's probably unlikely that users will start submitting reports with no logs and only curl calls, but it's something to think about if that situation does start to happen (I don't think it will, as it takes much more time to craft a curl call than to copy-paste log lines). |
|
I see your point on the dev-on-duty needs, @RedXanadu. Let's keep an eye on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rewritten the two issue templates from scratch. I thought it was necessary to make it clearer what we really need.