fix(test): update user-agent across all tests (#3136) #3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea523f0 to
48732ef
Compare
In order to add the new rule that checks for RCE in `User-Agent` and `Referer` headers, we need to update the default user agent string in all test cases to avoid triggering that rule for each test This commit fixes missed tests
48732ef to
34bcc12
Compare
|
@theseion I think you need to rebase this one, right? |
|
I don't think so... why? |
|
You only replaced quoted occurrences of the UA header. This commit replaces the unquoted instances. |
|
I need to merge this one too @fzipi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add the new rule that checks for RCE in
User-AgentandRefererheaders, we need to update the default user agent string in all test cases to avoid triggering that rule for each testThis commit fixes missed tests