feat: update word list for 932232 #3276
Conversation
7fd5d28 to
7e83627
Compare
|
Coming along nicely. How much more until this is a review-ready state? Also: I presume the update to this list can not be automated. Please confirm. |
|
I need to fix the tests, then it will be review ready. I will also see whether I can at least add one or two shell expressions to regenerate some of the lists from others. The list for PL 3 cannot be automated, unless we decide to throw away the current contents and come up with some rule to include certain entries in that list. |
|
Got you. I would rather refrain from too much acrobatics. I reckon we will revisit the automation for 4.1 and consolidate some list updates via the toolchain. That would be the moment to link the srcs of various rules. |
|
I've some additions for |
|
These are the additions in my fork:- Xhoenix@b9b6361 |
|
Nice addition @Xhoenix, but what the heck is |
|
My bad. Just adding stuff that came to my mind, forgot it was a builtin. |
|
Same for |
|
Thanks @Xhoenix, I'll merge those. |
|
Status as I see it:
Correct? |
|
I opened a new PR for the |
More or less :) |
f0c95a0 to
3da54e3
Compare
|
A couple of notes:
|
|
Wow, impressive. So ready for review? |
Yes, that's why I requested your review ;) Note that I updated the comment above with an additional point. |
With the changes to exclusions of unix shell command words, some tests no longer match. These have been turned into negative tests and copied to the next PL level rule as positive tests to test that exculsions work as intended.
The new automation script runs the list trough spell.sh to find english
words. These will be suffixed with `{{space-or-redirect}}` if they
aren't already.
Extend the automation script for unix-shell-upto3-for-cmdline.ra by running the words through spell.sh and suffixing English words with `@` automatically.
Add automation to unix-shell-fps-pl1.ra to add English words from the source lists automatically
The words passed to spell.sh may have suffixes that must be removed before passsing the words to wordnet. This commit adds the `-s` / `--suffix` flag which takes a regular expression used to strip suffixes from words.
The FreeBSD version of sed (as present under macOS) is incompatible with GNU sed w.r.t. the in-place flag `-i`. To ensure that the scripts work acrsoss platforms this commit replaces `sed -i` invocations with equivalent `ed` commands.
The FP exclusion files contain all variants of a word. Explain why that makes sense.
Various fixes to the scripts (some things only workded because I was pasting the script into my zsh shell). Scripts now run reliably under bash.
Some commands like `clang++` need to be escaped because they contain regular expression meta characters.
Some commands include a `.`. This character should be escaped, since it is, technically, a regular expression meta token.
0c4cad6 to
76a5a39
Compare
|
Adding the two variables to |
|
I think we're good. I suggest to remove mandatory review by @fzipi. @franbuehler and I looked at this in detail. Ready to be merged as far as I am concerned. |
|
"seal of checkmark"?? 🧐 |
Fixes #2692.