Backport v3.2 from v3.3 #3347
Closed
Backport v3.2 from v3.3 #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airween
requested changes
Oct 31, 2023
|  | ||
|  | ||
| [](https://www.owasp.org/index.php/OWASP_Project_Inventory#tab=Flagship_Projects) | ||
|  |
There was a problem hiding this comment.
Why do we want to add the next version's URL into the README? Is there any reason?
| # This would point to an attempt to inject a 2nd request into the request, thus bypassing | ||
| # tests carried out on the primary request. | ||
| # | ||
| # [ References ] | ||
| # http://projects.webappsec.org/HTTP-Request-Smuggling | ||
| # | ||
| SecRule ARGS_NAMES|ARGS|XML:/* "@rx [\n\r]+(?:get|post|head|options|connect|put|delete|trace|track|patch|propfind|propatch|mkcol|copy|move|lock|unlock)\s+[^\s]+(?:\s+http|[\r\n])" \ | ||
| SecRule ARGS_NAMES|ARGS|REQUEST_BODY|XML:/* "@rx (?:get|post|head|options|connect|put|delete|trace|track|patch|propfind|propatch|mkcol|copy|move|lock|unlock)\s+[^\s]+(?:\s+http\/\d|[\r\n])" \ |
There was a problem hiding this comment.
I think this modification is not complete, a part of the new regex is missing after unlock): (?:\/|\w). The line in 3.3 is this:
SecRule ARGS_NAMES|ARGS|REQUEST_BODY|XML:/* "@rx (?:get|post|head|options|connect|put|delete|trace|track|patch|propfind|propatch|mkcol|copy|move|lock|unlock)\s+(?:\/|\w)[^\s]*(?:\s+http\/\d|[\r\n])" \
| @@ -84,7 +84,7 @@ SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAME | |||
| setvar:'tx.anomaly_score_pl1=+%{tx.critical_anomaly_score}'" | |||
|
|
|||
|
|
|||
| SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAMES|ARGS|XML:/* "@rx (?:\bhttp\/(?:0\.9|1\.[01])|<(?:html|meta)\b)" \ | |||
| SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAMES|ARGS|XML:/* "@rx (?:\bhttp\/\d|<(?:html|meta)\b)" \ | |||
There was a problem hiding this comment.
I think there is an extra \ character here before the /\d. In 3.3 the operator's argument is this:
(?:\bhttp/\d|<(?:html|meta)\b)
(and not (?:\bhttp\/\d|<(?:html|meta)\b))
| tag:'language-multi',\ | ||
| tag:'platform-multi',\ | ||
| tag:'attack-protocol',\ | ||
| tag:'paranoia-level/1',\ |
There was a problem hiding this comment.
We do not have paranoia-level/N tags in 3.2, you should remove this tag.
| tag:'OWASP_CRS',\ | ||
| tag:'OWASP_CRS/WEB_ATTACK/HTTP_SPLITTING',\ | ||
| ctl:auditLogParts=+E,\ | ||
| ver:'OWASP_CRS/3.2.0',\ |
There was a problem hiding this comment.
Here you should add tag OWASP_CRS/3.2.3, not 3.2.0.
| @@ -121,7 +121,7 @@ SecRule ARGS "@rx ^(?i:file|ftps?|https?)://(.*)$" \ | |||
| severity:'CRITICAL',\ | |||
| setvar:'tx.rfi_parameter_%{MATCHED_VAR_NAME}=%{tx.1}',\ | |||
There was a problem hiding this comment.
An extra . (dot) is missing from here. The correct action is:
setvar:'tx.rfi_parameter_%{MATCHED_VAR_NAME}=.%{tx.1}',\
|
We have decided to close this PR and focus on the v4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i tried to focus on critical changes.
i skipped #1805 for example.