fix: move rule back to PL2 where it was originally supposed to be (934101 PL2) (Christian Folini) #3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4101 PL2) (Christian Folini)
RedXanadu
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule was contributed during the 2022 BB.
It was meant to be a stricter sibling, but it resided among the PL1 rules and we did not catch this during the review.
Later in 2022, when we cleaned up PL scoring variable bugs and tags, the rule was re-tagged as PL1 based on the position among the PL1 rules.
This PR moves the rule back to PL2.
This shift is needed so rule 934150 gets an isolated test at PL1 (as long as 934101 remains at PL1, 934101 will always trigger when testing for 934150 since 934101 happens to be a subset of 934150).