8000 feat: add test overrides for nginx by theseion · Pull Request #3369 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add test overrides for nginx #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 1, 2024
Merged

feat: add test overrides for nginx #3369

merged 18 commits into from
Jul 1, 2024

Conversation

theseion
Copy link
Contributor
@theseion theseion commented Nov 9, 2023

No description provided.

@theseion theseion marked this pull request as draft November 9, 2023 09:01
@theMiddleBlue theMiddleBlue added the ✌️ v3 Regression Tests Required PR for Nginx / libmodsecurity regression tests label Nov 11, 2023
8000
@theseion theseion force-pushed the nginx-expected-failures branch from 4175399 to afee93b Compare November 13, 2023 09:41
@dune73 dune73 added the v4 Should go into release v4 label Dec 12, 2023
@dune73
Copy link
Member
dune73 commented Dec 13, 2023

Thanks @theseion. Can we help you get this PR over the line? What is still missing here?

@theseion
Copy link
Contributor Author

Some finishing touches to go-ftw are needed. Need to pick up work on that again. Probably over Christmas.

@dune73
Copy link
Member
dune73 commented Dec 13, 2023

That's a reasonable time frame. Thanks for the info.

Do we need this for v4, or can the label be removed?

@theseion
8000 Copy link
Contributor Author

I think we can ship 4.0 without this.

@theseion theseion removed the v4 Should go into release v4 label Dec 13, 2023
@dune73
Copy link
Member
dune73 commented Dec 13, 2023

Thank you

@RedXanadu
Copy link
Member
RedXanadu commented Feb 24, 2024 •
edited
Loading

@theseion Is this still blocked by missing go-ftw features? I'd like to add the status of the nginx regression testing endeavour to the March agenda.

@theseion
Copy link
Contributor Author

Yes, I need to implement some things in go-ftw to support multiple engines, the status engine, etc.

@github-actions github-actions bot added the Stale label Mar 27, 2024
@fzipi fzipi removed the Stale label Apr 1, 2024
@github-actions github-actions bot added the Stale label May 2, 2024
@theseion theseion force-pushed the nginx-expected-failures branch from afee93b to 3c3c5e8 Compare May 4, 2024 21:12
@github-actions github-actions bot removed the Stale label May 5, 2024
@theseion theseion force-pushed the nginx-expected-failures branch from 3c3c5e8 to c2eef52 Compare May 5, 2024 19:54
@dune73
Copy link
Member
dune73 commented May 8, 2024

Keeping my fingers crossed here ... :)

@theseion theseion force-pushed the nginx-expected-failures branch from c2eef52 to f877cc6 Compare May 10, 2024 06:35
@theseion theseion mentioned this pull request May 10, 2024
Merged
@theseion theseion force-pushed the nginx-expected-failures branch 3 times, most recently from 5f344d0 to 85b5606 Compare June 1, 2024 18:47
@theseion theseion changed the base branch from v4.0/dev to main June 1, 2024 18:51
@theseion theseion force-pushed the nginx-expected-failures branch from 9e78ce7 to 246116b Compare June 8, 2024 17:42
@theseion theseion marked this pull request as ready for review June 14, 2024 16:23
M4tteoP
M4tteoP reviewed Jun 17, 2024
View reviewed changes
fzipi
fzipi requested changes Jun 17, 2024
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME! Hopefully we can iterate quickly on this one.

fzipi
fzipi requested changes Jun 17, 2024
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME! Hopefully we can iterate quickly on this one.

@theseion theseion force-pushed the nginx-expected-failures branch from 2361f94 to c8d3f52 Compare June 30, 2024 12:16
@theseion
Copy link
Contributor Author

@fzipi rebased.

fzipi
fzipi reviewed Jul 1, 2024
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theseion So, after the correctness checks, what is your plan here?

I mean, from what I see there is no actual nginx test being run here, right? (e.g. matrix doesn't run for modsec3-nginx)

Are we first pushing this change, then adding it to the matrix? Maybe we want also to rename the matrix variable to platform instead of modsec_version....

@theseion
Copy link
Contributor Author
theseion commented Jul 1, 2024

I mean, from what I see there is no actual nginx test being run here, right? (e.g. matrix doesn't run for modsec3-nginx)

Are we first pushing this change, then adding it to the matrix? Maybe we want also to rename the matrix variable to platform instead of modsec_version....

I wanted to create a separate PR for both of those.

Once we've merged, I'll also open a PR for submitting the JSON schemas to schemastore.org (already prepared).

I haven't yet had a good idea on how to make people aware of the mapping between go-ftw and ftw-tests-schema. I thought about adding a schema version to the spec but that feels a bit clunky.
Another idea would be to make go-ftw fail hard whenever it can't parse a file. I actually changed go-ftw just recently to behave exactly the opposite way and be tolerant of things it doesn't know and simply log warnings. The reason for that was that the globbing very easily leads to inclusion of other files, and when that happens it's very hard for the user to figure out why go-ftw is failing.

Maybe we should couple the versioning of schema and go-ftw. Not a fan of t F438 hat either though...

fzipi
fzipi approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I can't see these last two. But they can be forgotten, as they are URL changes.

@fzipi fzipi mentioned this pull request Jul 1, 2024
Closed
@theseion theseion added this pull request to the merge queue Jul 1, 2024
Merged via the queue into coreruleset:main with commit c9deacf Jul 1, 2024
4 checks passed
@theseion theseion deleted the nginx-expected-failures branch July 1, 2024 18:12
@theseion
Copy link
Contributor Author
theseion commented Jul 1, 2024

They were hidden (happens when there are too many conversations).

@fzipi fzipi mentioned this pull request Jul 23, 2024
Merged
@airween airween mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@M4tteoP M4tteoP Awaiting requested review from M4tteoP

Assignees
No one assigned
Labels
✌️ v3 Regression Tests Required PR for Nginx / libmodsecurity regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theseion @dune73 @RedXanadu @fzipi @M4tteoP @theMiddleBlue
0