8000 feat: new isolated test 920290-4 (920290 PL1) (Christian Folini) by dune73 · Pull Request #3370 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: new isolated test 920290-4 (920290 PL1) (Christian Folini) #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2023
Merged

feat: new isolated test 920290-4 (920290 PL1) (Christian Folini) #3370

merged 2 commits into from
Nov 9, 2023

Conversation

dune73
Copy link
Member
@dune73 dune73 commented Nov 9, 2023

Status page test. See #3351

@dune73 dune73 requested a review from franbuehler November 9, 2023 10:14
@dune73 dune73 mentioned this pull request Nov 9, 2023
Closed
franbuehler
franbuehler approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor
@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only this rule is triggered by the test. However this rule only has severity "WARNING", so we'll not get a block if the threshold is configured to 5. We should have this in mind for testing the cloud!

@franbuehler franbuehler merged commit 4cd4925 into v4.0/dev Nov 9, 2023
@fzipi fzipi mentioned this pull request Dec 4, 2023
Closed
@fzipi fzipi deleted the test-920290-4 branch February 14, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franbuehler franbuehler franbuehler approved these changes

Assignees

@franbuehler franbuehler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dune73 @franbuehler
0