8000 fix: 932236 932237 932239 FP with word settings by EsadCetiner · Pull Request #3394 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: 932236 932237 932239 FP with word settings #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jan 10, 2024
Merged

fix: 932236 932237 932239 FP with word settings #3394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b2645bb
fix: 932239 932237 932236 settings FP
EsadCetiner Nov 29, 2023
701647b
fix: setting FP by adding @
EsadCetiner Nov 29, 2023
2d4c820
test: add regression test for FP settings 932236
EsadCetiner Nov 29, 2023
9529f98
test: add regression test for FP settings 932237
EsadCetiner Nov 29, 2023
83e82f3
test: add regression test for FP settings 932239
EsadCetiner Nov 29, 2023
f5ca213
test: fix failing regression tests
EsadCetiner Nov 29, 2023
afc9507
test: fix failing regression tests
EsadCetiner Nov 29, 2023
234ad4c
Merge branch 'v4.0/dev' into v4.0/dev
EsadCetiner Nov 30, 2023
3c7a87d
test: another attempt to fix failing tests 932237
EsadCetiner Dec 1, 2023
967770c
Merge branch 'v4.0/dev' into v4.0/dev
EsadCetiner Dec 9, 2023
d0ebaf1
test: update payload and don't reference github issue
EsadCetiner Dec 13, 2023
53cb511
test: don't reference github issue
EsadCetiner Dec 13, 2023
8adf2cb
test: don't reference github issue
EsadCetiner Dec 13, 2023
f1a393c
test: don't reference github issue
EsadCetiner Dec 13, 2023
6684217
test: use same http verb for URI path
EsadCetiner Dec 13, 2023
7f0c272
test: use same http verb for URI path
EsadCetiner Dec 13, 2023
c2cd6bf
test: use same http verb for URI path
EsadCetiner Dec 13, 2023
629eec5
Merge branch 'v4.0/dev' into v4.0/dev
EsadCetiner Jan 5, 2024
2cf4836
fix: update regex
EsadCetiner Jan 5, 2024
e3fb9d9
test: delete old tests
EsadCetiner Jan 5, 2024
8a99872
Merge branch 'v4.0/dev' into v4.0/dev
theseion Jan 5, 2024
95596ca
test: revert commit e3fb9d9 and fix failing tests
EsadCetiner Jan 7, 2024
5a31328
Merge branch 'v4.0/dev' into v4.0/dev
EsadCetiner Jan 8, 2024
4c83a5c
Merge branch 'v4.0/dev' into v4.0/dev
EsadCetiner Jan 10, 2024
6f9108c
fix: update regex
EsadCetiner Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion regex-assembly/include/unix-shell-upto3.ra
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ rm@
rpm@
scp
sed@
set
set@
sg@
sh@
ss@
Expand Down
6 changes: 3 additions & 3 deletions rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 20 additions & 4 deletions tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/932236.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ tests:
output:
no_log_contains: id "932236"
- test_title: 932236-19
desc: "FP MailerUI GitHub Issue #3220"
desc: "FP MailerUI"
stages:
- stage:
input:
Expand All @@ -349,7 +349,7 @@ tests:
output:
no_log_contains: id "932236"
- test_title: 932236-20
desc: "FP tasksListView GitHub Issue #3220"
desc: "FP tasksListView"
stages:
- stage:
input:
Expand Down Expand Up @@ -807,7 +807,7 @@ tests:
output:
log_contains: id "932236"
- test_title: 932236-44
desc: "FP with word comment Github Issue #3387"
desc: "FP with word comment"
stages:
- stage:
input:
Expand All @@ -818,7 +818,23 @@ tests:
Accept: "text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
method: GET
port: 80
uri: /?args=comment
uri: /get?args=comment
version: HTTP/1.0
output:
no_log_contains: id "932236"
- test_title: 932236-45
desc: "FP with word settings"
stages:
- stage:
input:
dest_addr: 127.0.0.1
headers:
User-Agent: "OWASP CRS test agent"
Host: localhost
Accept: "text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
method: GET
port: 80
uri: /get?args=settings
version: HTTP/1.0
output:
no_log_contains: id "932236"
42 changes: 29 additions & 13 deletions tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/932237.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ tests:
User-Agent: env
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: "/"
uri: "/get"
protocol: "http"
output:
log_contains: "id \"932237\""
Expand All @@ -30,7 +30,7 @@ tests:
User-Agent: id
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: "/"
uri: "/get"
protocol: "http"
output:
log_contains: "id \"932237\""
Expand Down Expand Up @@ -59,7 +59,7 @@ tests:
User-Agent: settings
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: '/'
uri: '/get'
protocol: "http"
output:
no_log_contains: "id \"932237\""
Expand All @@ -74,7 +74,7 @@ tests:
User-Agent: environment
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: '/'
uri: '/get'
protocol: "http"
output:
no_log_contains: "id \"932237\""
Expand All @@ -90,7 +90,7 @@ tests:
Referer: env
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: "/"
uri: "/get"
protocol: "http"
output:
log_contains: "id \"932237\""
Expand All @@ -106,7 +106,7 @@ tests:
Referer: id
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: "/"
uri: "/get"
protocol: "http"
output:
log_contains: "id \"932237\""
Expand Down Expand Up @@ -137,7 +137,7 @@ tests:
Referer: settings
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: '/'
uri: '/get'
protocol: "http"
output:
no_log_contains: "id \"932237\""
Expand All @@ -153,7 +153,7 @@ tests:
Referer: environment
Host: "localhost"
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
uri: '/'
uri: '/get'
protocol: "http"
output:
no_log_contains: "id \"932237\""
Expand Down Expand Up @@ -194,7 +194,7 @@ tests:
output:
no_log_contains: "id \"932237\""
- test_title: 932237-13
desc: "FP with word comment Github Issue #3387"
desc: "FP with word comment"
stages:
- stage:
input:
Expand All @@ -205,11 +205,27 @@ tests:
Accept: "text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
method: GET
port: 80
uri: /
uri: /get
version: HTTP/1.0
output:
no_log_contains: id "932237"
- test_title: 932237-14
desc: "FP with word settings"
stages:
- stage:
input:
dest_addr: 127.0.0.1
headers:
User-Agent: "https://example.com/?args=settings"
Host: localhost
Accept: "text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
method: GET
port: 80
uri: /get
version: HTTP/1.0
output:
no_log_contains: id "932237"
- test_title: 932237-15
stages:
- stage:
input:
Expand All @@ -223,8 +239,8 @@ tests:
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
protocol: "http"
output:
log_contains: "id \"932237\""
- test_title: 932237-15
no_log_contains: "id \"932237\""
- test_title: 932237-16
stages:
- stage:
input:
Expand All @@ -237,4 +253,4 @@ tests:
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
protocol: "http"
output:
log_contains: "id \"932237\""
no_log_contains: "id \"932237\""
40 changes: 28 additions & 12 deletions tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/932239.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ tests:
User-Agent: ";chmod +x evil.php"
method: GET
port: 80
uri: /
uri: /get
version: HTTP/1.0
output:
log_contains: id "932239"
Expand All @@ -37,7 +37,7 @@ tests:
User-Agent: ";CHMOD +X EVIL.PHP"
method: GET
port: 80
uri: /
uri: /get
version: HTTP/1.0
output:
log_contains: id "932239"
Expand Down Expand Up @@ -192,7 +192,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -210,7 +210,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -228,7 +228,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -246,7 +246,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -264,7 +264,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -282,7 +282,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -300,7 +300,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand All @@ -318,7 +318,7 @@ tests:
Accept-Language: en-us,en;q=0.5
method: GET
port: 80
uri: "/"
uri: "/get"
version: HTTP/1.1
output:
no_log_contains: id "932239"
Expand Down Expand Up @@ -356,7 +356,7 @@ tests:
output:
log_contains: id "932239"
- test_title: 932239-20
desc: "FP with word comment Github Issue #3387"
desc: "FP with word comment"
stages:
- stage:
input:
Expand All @@ -367,7 +367,23 @@ tests:
Accept: "text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
method: GET
port: 80
uri: /
uri: /get
version: HTTP/1.0
output:
no_log_contains: id "932239"
- test_title: 932239-21
desc: "FP with word settings"
stages:
- stage:
input:
dest_addr: 127.0.0.1
headers:
User-Agent: "https://example.com/?args=settings"
Host: localhost
Accept: "text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"
method: GET
port: 80
uri: /get
version: HTTP/1.0
output:
no_log_contains: id "932239"
0