8000 chore: changelog updates for 2023-12-13, merged by @dune73 by theseion · Pull Request #3421 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: changelog updates for 2023-12-13, merged by @dune73 #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

theseion
Copy link
Contributor

This PR was auto-generated to update the changelog with the following entries, merged by @dune73:

* fix: 934130 and 934131 rules (Andrea Menin) [#3378]

@theseion theseion added the changelog-pr Changelog update automation label Dec 14, 2023
@dune73
Copy link
Member
dune73 commented Dec 14, 2023

How would you describe this change for the changelog @theMiddleBlue? See examples in the CHANGES.md file.

@theMiddleBlue
Copy link
Contributor

can it be made of 2 entries? if yes:

- Removed rule 934131 at PL2 for being overly specific with limited benefits and lack of cross-engine compatibility.
- Removed base64 transformation function from rule 934130 to align behavior across ModSecurity v2.x and libModSecurity v3.x engines, and due to limited effectiveness.

@dune73
Copy link
Member
dune73 commented Dec 14, 2023

Fair enough. I suggest the final entry as follows:

fix: remove overly specific rule with limited benefits and lack of cross-engine compatibility (934131 PL2) (Andrea Menin)
fix: remove base64 transformation due to limited effectiveness an to align behavior across ModSecurity v2.x and libModSecurity v3.x engines (934130 PL1) (Andrea Menin)

Thank you.

OK?

@theMiddleBlue
Copy link
Contributor

ok for me thx

@dune73
Copy link
Member
dune73 commented Dec 14, 2023

@theMiddleBlue : I adopted this. Please check, approve and merge

@theMiddleBlue theMiddleBlue merged commit 53a611b into coreruleset:v4.0/dev Dec 14, 2023
@theseion theseion deleted the changelog-updates-for-2023-12-13-dune73 branch December 14, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-pr Changelog update automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0