fix: match non-word-boundary of commands with options #3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix commands such as `dig` require options or they won't run. `dig` uses the `@` anti-evasion pattern (e.g., for 932237). For a command such as `dig --help`, the final word boundary (`\b`) in 932237 actually prevents a match. The `@` causes `dig ` to be matched, but the word boundary will not match because both the space character and the dash character are in `\W` (for `\b` to match, one of them would have to be in `\w`). This commit modifies the final word boundary of 932237 to `(?:\b|\W)`, in order to fix this. Note that the final expression must work for commands without options, commands with options (`@`) and for command prefixes (`~`, e.g., `gcc` or `pip`). Fixes coreruleset#3401
|
@EsadCetiner: Since you discovered this issue, can we have your feedback before we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unix commands such as
digrequire options or they won't run.diguses the@anti-evasion pattern (e.g., for 932237). For a command such asdig --help, the final word boundary (\b) in 932237 actually prevents a match. The@causesdigto be matched, but the word boundary will not match because both the space character and the dash character are in\W(for\bto match, one of them would have to be in\w).This commit modifies the final word boundary of 932237 to
(?:\b|\W), in order to fix this.Note that the final expression must work for commands without options, commands with options (
@) and for command prefixes (~, e.g.,gccorpip).Fixes #3401