fix: remove chain rule from 932260 #3521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
932260 was copied from 932240, which includes a chain rule to prevent false positives against number separators. This chain rule makes no sense for 932260 and is actually detrimental, as it enables trivial bypasses. See coreruleset#3147
69f002f to
449cc11
Compare
franbuehler
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
I tested this PR. It works and solves the latest open problem in #3147 with `?a=whoami;0'0'? .
After merging this PR here, the mentioned issue can be closed.
|
@fzipi Please review this PR too. I want to be sure that the removal of the chain rule is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
932260 was copied from 932240, which includes a chain rule to prevent false positives against number separators. This chain rule makes no sense for 932260 and is actually detrimental, as it enables trivial bypasses.