8000 feat: added arithmetic expansion payload by Xhoenix · Pull Request #3756 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: added arithmetic expansion payload #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 6, 2024
Merged

feat: added arithmetic expansion payload #3756

merged 12 commits into from
Jul 6, 2024

Conversation

Xhoenix
Copy link
Member
@Xhoenix Xhoenix commented Jul 4, 2024

Bash - Arithmetic expansion: $[2+2]

@Xhoenix Xhoenix changed the title feat: added arithmetic expansion payload feat: added arithmetic expansion payload Jul 4, 2024
@Xhoenix Xhoenix requested a review from theseion July 4, 2024 07:19
Copy link
Contributor
@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! It's deprecated in bash and isn't even documented in the bash man page on my machine 😓.

Xhoenix and others added 7 commits July 5, 2024 09:52
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
…30.yaml

Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
…30.yaml

Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
@theseion
Copy link
Contributor
theseion commented Jul 6, 2024

932300-9 is failing.

@theseion theseion added this pull request to the merge queue Jul 6, 2024
Merged via the queue into coreruleset:main with commit c80e8ba Jul 6, 2024
4 checks passed
@theseion theseion added the release:new-detection In this PR we introduce a new detection label Jul 9, 2024
@fzipi fzipi mentioned this pull request Jul 23, 2024
TimDiam0nd added a commit to TimDiam0nd/coreruleset that referenced this pull request Feb 25, 2025
The expect id for the test 932230-58 was set to 932130, when in fact it should be 932230.
It is more than probable that it was copy pasted from the test for 932130 but @Xhoenix forget to update it.
Relevant pr: coreruleset#3756
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
* Fix incorrect id for 932230-58

The expect id for the test 932230-58 was set to 932130, when in fact it should be 932230.
It is more than probable that it was copy pasted from the test for 932130 but @Xhoenix forget to update it.
Relevant pr: #3756

* adjust payload so it triggers the rule

---------

Co-authored-by: Xhoenix <86168235+Xhoenix@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:new-detection In this PR we introduce a new detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0