-
-
Notifications
You must be signed in to change notification settings - Fork 402
feat: added arithmetic expansion payload #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! It's deprecated in bash and isn't even documented in the bash man page on my machine 😓.
tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/932130.yaml
Outdated
Show resolved
Hide resolved
tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/932230.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
…30.yaml Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
…30.yaml Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com>
932300-9 is failing. |
theseion
approved these changes
Jul 6, 2024
Merged
TimDiam0nd
added a commit
to TimDiam0nd/coreruleset
that referenced
this pull request
Feb 25, 2025
The expect id for the test 932230-58 was set to 932130, when in fact it should be 932230. It is more than probable that it was copy pasted from the test for 932130 but @Xhoenix forget to update it. Relevant pr: coreruleset#3756
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
* Fix incorrect id for 932230-58 The expect id for the test 932230-58 was set to 932130, when in fact it should be 932230. It is more than probable that it was copy pasted from the test for 932130 but @Xhoenix forget to update it. Relevant pr: #3756 * adjust payload so it triggers the rule --------- Co-authored-by: Xhoenix <86168235+Xhoenix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash - Arithmetic expansion: $[2+2]