fix: tests typos #3794
Merged
fix: tests typos #3794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzipi
approved these changes
Aug 16, 2024
|
Thanks for the fixes @TimDiam0nd! |
mat1010
pushed a commit
to mat1010/coreruleset
that referenced
this pull request
Aug 17, 2024
* fix no_expect_ids typo * fix expect_ids not nested under "log"
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Check REQUEST_FILENAME in 942160 * Add negative tests * Remove obsolete REQUEST_BASENAME check * Handle comments in rule 942160, add tests * fix: update ``docker-compose`` to ``docker compose`` (#3784) * fix: Update 932270's ver (#3786) * perf: remove unnecessary chain rule and capture for 921180 (#3787) * perf: remove unnecessary chain rule and capture for 921180 * fix: 921180 not logging ``logdata`` correctly * feat: Check that all rules have the correct CRS tag and version (#3788) * Check that all rules have the correct CRS tag and version * Change regexes to raw string; added 'git fetch --tags' before version determined * Print commands' outputs to debug script * Remove unnecessary subprocess commands * Fetch tags before check * Run git describe cmd * chore: fetch enough commits for `git describe` to discover tags * Update util/crs-rules-check/rules-check.py Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Update util/crs-rules-check/rules-check.py Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Update util/crs-rules-check/rules-check.py Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Update util/crs-rules-check/rules-check.py Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Update util/crs-rules-check/rules-check.py Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Change message type format Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Change message type format Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Use `str` to convert string value Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Change variable type format Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Add triple " to formatted string * Change message type format Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Remove unnecessary escapes Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Change regex format to raw string Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Change regex format to raw string Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * Remove unnecessary escapes Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> --------- Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> * fix: add pem to restricted file extensions (#3789) * fix: add pem to restricted file extensions * chore: add esad cetiner to authors in 920440 tests * docs: improve documentationt of 941160 (#3790) Refs #3770 * fix: tests typos (#3794) * fix no_expect_ids typo * fix expect_ids not nested under "log" --------- Co-authored-by: Esad Cetiner <104706115+EsadCetiner@users.noreply.github.com> Co-authored-by: Ervin Hegedus <airween@gmail.com> Co-authored-by: Max Leske <250711+theseion@users.noreply.github.com> Co-authored-by: TimDiam0nd <54599998+TimDiam0nd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two typos:
no_expectIdsinstead ofno_expect_idsexpect_idswas directly underoutput, instead of being nested underlogi.e.output->log->expect_ids