8000 feat: add new rule to catch invalid character in multipart headers by airween · Pull Request #3796 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add new rule to catch invalid character in multipart headers #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 26, 2024
Merged

feat: add new rule to catch invalid character in multipart headers #3796

merged 24 commits into from
Aug 26, 2024

Conversation

airween
Copy link
Contributor
@airween airween commented Aug 19, 2024 •
edited by fzipi
Loading

Add a new rule 922130 which check if any MULTIPART header contains a non-ascii character.

Fixes 3MU-240701-1 by @luelueking for v4.

@airween airween requested review from fzipi and theseion August 19, 2024 21:38
fzipi
fzipi reviewed Aug 19, 2024
View reviewed changes
fzipi
fzipi reviewed Aug 19, 2024
View reviewed changes
@fzipi fzipi changed the title feat: Add new rule to catch invalid character in multipart headers feat: add new rule to catch invalid character in multipart headers Aug 19, 2024
airween and others added 2 commits August 19, 2024 23:47
@airween @fzipi
Change tag 'deprecated' to 'multipart'
ca22ef0 
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
@airween @fzipi
Added '?' after '<' for the correct PHP open tag
4b3ee57 
Co-authored-by: Felipe Zipitría <3012076+fzipi@users.noreply.github.com>
fzipi
fzipi previously approved these changes Aug 19, 2024
View reviewed changes
theseion
theseion requested changes Aug 20, 2024
View reviewed changes
huberts90
huberts90 reviewed Aug 20, 2024
View reviewed changes
@airween airween requested a review from theseion August 20, 2024 15:52
@airween
Copy link
Contributor Author
airween commented Aug 20, 2024

I think I'm done with this PR.

fzipi
fzipi reviewed Aug 20, 2024
View reviewed changes
theseion
theseion requested changes Aug 21, 2024
View reviewed changes
theseion
theseion requested changes Aug 21, 2024
View reviewed changes
theseion
theseion requested changes Aug 22, 2024
View reviewed changes
theseion
theseion requested changes Aug 25, 2024
View reviewed changes
theseion
theseion requested changes Aug 26, 2024
View reviewed changes
@airween airween requested a review from theseion August 26, 2024 09:57
@fzipi fzipi requested review from fzipi and huberts90 August 26, 2024 11:37
@fzipi
Copy link
Member
fzipi commented Aug 26, 2024

JFYI: I'll wait until this one is merged with the definitive rule and test to do the backporting.

@airween
Copy link
Contributor Author
airween commented Aug 26, 2024

@theseion - thanks for all of your help.
@fzipi, @huberts90 - do you want to take a review?

fzipi
fzipi approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks everyone 🙂

@fzipi fzipi added this pull request to the merge queue Aug 26, 2024
Merged via the queue into coreruleset:main with commit 43c53f4 Aug 26, 2024
4 checks passed
@fzipi fzipi mentioned this pull request Sep 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

@fzipi fzipi fzipi approved these changes

@huberts90 huberts90 Awaiting requested review from huberts90

Assignees
4F82 No one assigned
Labels
release:important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@airween @fzipi @theseion @huberts90
0