8000 fix: fp with name axel by removing it from rce rule (932260 PL1) by franbuehler · Pull Request #3705 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ coreruleset Public

fix: fp with name axel by removing it from rce rule (932260 PL1) #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2024
Merged

fix: fp with name axel by removing it from rce rule (932260 PL1) #3705

merged 4 commits into from
May 19, 2024

Conversation

franbuehler
Copy link
Contributor

This PR resolves #3644 by removing the German name Axel from RCE rule 932260. It also adds a test to validate the removal of the FP.

theseion
theseion requested changes May 19, 2024
View reviewed changes
@franbuehler franbuehler requested a review from theseion May 19, 2024 10:26
@franbuehler
Copy link
Contributor Author

Thank you for the review @theseion.

theseion
theseion requested changes May 19, 2024
View reviewed changes
Copy link
Contributor
@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that.

@franbuehler @theseion
Update tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/9322…
a32adc4 
…60.yaml

Co-authored-by: Max Leske <th3s3ion@gmail.com>
@franbuehler franbuehler added this pull request to the merge queue May 19, 2024
Merged via the queue into coreruleset:main with commit 742309b May 19, 2024
4 checks passed
@franbuehler franbuehler deleted the fix-fp-axel branch May 19, 2024 18:10
@fzipi fzipi changed the title fix: fix fp with name axel by removing it from rce rule (932260 PL1) fix: fp with name axel by removing it from rce rule (932260 PL1) May 20, 2024
@dune73 dune73 mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP 932260: Name of "Axel"
3 participants
@franbuehler @theseion @fzipi
0