fix: fp with user-agent containing ; pg (932239 PL2) #3727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azurit
reviewed
Jun 2, 2024
tests/regression/tests/REQUEST-932-APPLICATION-ATTACK-RCE/932239.yaml
Outdated
Show resolved
Hide resolved
|
What exactly will this PR cause? Will it exclude |
Yes, exactly. |
|
That doesn't seems fully correct to me, as we are having FPs with |
|
Yes, true. So, to match |
|
I don't know why test 932300 is failing. I had to run |
Replace HTTP/1.0 with HTTP/1.1 in the tests
cdf77be to
3d99114
Compare
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
3d99114 to
df3ebb8
Compare
RedXanadu
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggesti
2E85
ons on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #3725 by adding a
@topgto the file unix-shell-upto3.ra. It also adds a test.