8000 fix(933120): do not match on base64 encoded strings by fzipi · Pull Request #3863 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(933120): do not match on base64 encoded strings #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix(933120): do not match on base64 encoded strings #3863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
907711c
fix(933120): do not match on base64 encoded strings
fzipi Oct 16, 2024
8ff7aff
Merge branch 'main' into fix/3723
fzipi Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/REQUEST-933-APPLICATION-ATTACK-PHP.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ SecRule REQUEST_COOKIES|!REQUEST_COOKIES:/__utm/|REQUEST_COOKIES_NAMES|ARGS_NAME
setvar:'tx.933120_matched_var=%{MATCHED_VAR}',\
setvar:'tx.933120_matched_var_name=%{MATCHED_VAR_NAME}',\
chain"
SecRule MATCHED_VARS "@rx \b([^\s]+)\s*=" \
SecRule MATCHED_VARS "@rx \b([^\s]+)\s*=(?:\w+)" \
"capture,\
chain"
SecRule TX:1 "@pmFromFile php-config-directives.data" \
Expand Down
17 changes: 17 additions & 0 deletions tests/regression/tests/REQUEST-933-APPLICATION-ATTACK-PHP/933120.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,20 @@ tests:
output:
log:
expect_ids: [933120]
- test_id: 10
desc: "FP PHP Injection Attack: prevent matching base64 encoded requests"
stages:
- input:
dest_addr: 127.0.0.1
headers:
Host: "localhost"
Cache-Control: "no-cache, no-store, must-revalidate"
User-Agent: "OWASP CRS test agent"
Accept: "*/*"
method: GET
uri: "/get?SAMLRequest=mhXNy9pMlFhTjBlRkkzSkpia1Y2cSMtPEE9PTwvc2FtbDpBdHRyaWJ1dGVWYWx1ZT48L3NhbWw6QXR0cmlidXRlPjwvc2FtbDpBdHRyaWJ1dGVTdGF0ZW1lbnQ+PC9zYW1sOkFzc2VydGlvbj48L3NhbWxwOlJlc3BvbnNlPg=="
port: 80
version: HTTP/1.1
output:
log:
no_expect_ids: [933120]
0