fix: change unnecessary capture groups to non capturing #3833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TimDiam0nd Can you run crs-toolchain to update all the involved regexes? |
|
@TimDiam0nd did you close this PR on purpose? |
Yep, had some issues which i thought were due to me messing my branch up, hence force pushing. I did open a new pr #3849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rule id
955110the current regex is:(<title>r57 Shell Version [0-9.]+</title>|<title>r57 shell</title>), but is not used.For rule id
934120the ra contains a capture group added by @theseion , though it likewise does not appear to be used.