fix: move rule's phase 950100 to 3 #3941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: release v3.3.7
This was referenced Nov 18, 2024
|
I would say yes, we want to move all the rules than can be moved to phase 3 if the condition is applying on response headers only. |
fzipi
approved these changes
Nov 18, 2024
Thanks, I merged this one into I'll open a new PR soon to fix the other phases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule 950100 in branch v3.3 has the
phase:4, but it could be inphase:3.There is an open issue about this problem: #3936, where the reporter describes the details. Also he mentioned my previously PR #1941, but it made for v3.4 (which wasn't released) and we haven't back-ported anything.
This PR only moves one rule's phase, but there are many other rules where we can make this step - the question is do we want to do this or not.