8000 fix: make 932300 actually case-insensitive by theseion · Pull Request #3977 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make 932300 actually case-insensitive #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: make 932300 actually case-insensitive #3977

merged 1 commit into from
Jan 10, 2025

Conversation

theseion
Copy link
Contributor
  • properly apply regex flags
  • clean up regular expressions

@theseion theseion requested a review from a team January 10, 2025 07:24
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 10, 2025 •
edited
Loading

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@theseion
fix: make 932300 actually case-insensitive
bc92571 
- properly apply regex flags
- clean up regular expressions
franbuehler
franbuehler approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor
@franbuehler franbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theseion theseion added this pull request to the merge queue Jan 10, 2025
Merged via the queue into coreruleset:main with commit 412f32b Jan 10, 2025
6 checks passed
@theseion theseion deleted the cleanup-932300 branch January 10, 2025 18:33
@fzipi fzipi mentioned this pull request Feb 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franbuehler franbuehler franbuehler approved these changes

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @franbuehler
0