-
-
Notifications
You must be signed in to change notification settings - Fork 401
feat: add potential malicious file extensions into tx.restricted_extensions #4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add potential malicious file extensions into tx.restricted_extensions #4068
Conversation
📊 Quantitative test results for language: |
I think we can exclude the |
Of course you cannot block You need to update also |
We cannot block also |
Looks ok for me but someone other should look at it, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Let's see if we start getting FPs with some extension or not.
That's quite a few new entries being added, I'm concerned this will cause false positives especially since they're from an LLM. Copilot isn't explaining how these files relate to web app security, but more around security for desktop computers. I'm having a pretty hard time imagining how accessing some of these files can be harmful, we should remove them if we can't think of a reasonable attack scenario. A fair few of these are stuff like fonts, Window's cursor files, Windows 7 era gadget files, etc .hta should definitely be removed since it's a legacy file format for Internet Explorer (Yes I know who uses IE, but I can't even think of a viable attack scenario for accessing this file) .crt files are just certificate files, these are meant to be public but I guess somebody could accidently store a private key as an .crt file. |
Fixes #3143
Source: Copilot chat