fix: fixing FPs related to rule 951220 #4079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📊 Quantitative test results for language: |
Xhoenix
reviewed
Apr 2, 2025
Xhoenix
reviewed
Apr 2, 2025
Xhoenix
approved these changes
Apr 2, 2025
|
I understand the change, but just in case, can we provide tests to see that everything is working as expected for this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting lots of FPs from rule
951220because of these two patterns:Both of them are too wide and general - mainly the second one is matching literally any text which contains
SQL Serverkeyword. As i was not able to find any MS SQL server error messages which these two patters are supposed to match (so i'm not able to improve/fix it), i suggest to remove them.Also, i improved one other pattern: 128 is a maximum length of procedure/function name in MS SQL Server.