8000 fix(933160): use better regex by fzipi · Pull Request #4010 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(933160): use better regex #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix(933160): use better regex #4010

merged 2 commits into from
Feb 24, 2025

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Feb 23, 2025

what

  • update regex to be more specific
  • change from . (anything) to [^)], which performs better while keeping the semantic

why

  • follow standards
  • optimize matching speed
  • prevent potential backtrackings

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from theseion February 23, 2025 15:41
Copy link
Contributor
github-actions bot commented Feb 23, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from theseion February 23, 2025 20:46
@theseion theseion added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit c023ef1 Feb 24, 2025
6 checks passed
@theseion theseion deleted the rules/933160-use-lazy-regex branch February 24, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0