8000 fix(941210): update log message to reflect rule javascript word detection by fzipi · Pull Request #4023 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(941210): update log message to reflect rule javascript word detection #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix(941210): update log message to reflect rule javascript word detection #4023

merged 1 commit into from
Feb 27, 2025

Conversation

fzipi
Copy link
Member
@fzipi fzipi commented Feb 27, 2025

what

  • regex-assembly file has a clear description of the rule detection target
  • update message to match said target

why

  • documentation
  • set expectation and clear meaning. previous was ambiguous and rather useless

@fzipi
fix(941210): update log message to reflect rule javascript word detec…
87ee846 
…tion

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi requested a review from a team February 27, 2025 12:11
@github-actions GitHub Actions
Copy link
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@fzipi fzipi added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 941bb73 Feb 27, 2025
6 checks passed
@fzipi fzipi deleted the chore/fix-941210-rule-message branch February 27, 2025 16:28
@fzipi fzipi mentioned this pull request Mar 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
release:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @theseion
0