feat: added zmodload #4143
feat: added zmodload #4143
Conversation
|
📊 Quantitative test results for language: |
There was a problem hiding this comment.
Add zmodload to unix-shell.data, then update unix-shell-4andup.ra using the script in the header.
There was a problem hiding this comment.
zmodload is a builltin. I thought the file was for variables and binaries.
There was a problem hiding this comment.
Good point. However, we also have environment variables in that file and from a usage point, a binary on the path is usable the same way as a builtin. I'd say, add it to the list and add a comment to the header, explaining that the list also contains builtins.
There was a problem hiding this comment.
That'd mean we need to cover a lot of other builtins, probably another PR? I only came up with zmodload because I realized how dangerous it's usage can be.
There was a problem hiding this comment.
There are probably tons of builtins we don't cover today, so every addition is good.
There was a problem hiding this comment.
I can't find any reference to alias binary(e.g., apt-file search alias | grep /bin/alias), but alias is added, probably a oversight.
coreruleset/rules/unix-shell.data
Line 44 in 6a9bf20
There was a problem hiding this comment.
Correct. That used to be just alias in 932100. Nice find.
There was a problem hiding this comment.
I noticed some others: fg, bg, chdir etc. There could be more.
There was a problem hiding this comment.
Some more (for a new PR maybe):
bin/builtinbin/donebin/endifbin/endswbin/esacbin/fibin/foreachbin/functionbin/historybin/hupbin/repeatbin/setbin/setenv
Some others are builtins, but also exist as separated binaries so we cannot remove:
bin/echobin/localbin/printenv
And maybe we also want to add sudo-rs? reference
No description provided.