8000 fix: remove rc shell to reduce FPs by theseion · Pull Request #4125 · coreruleset/coreruleset · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: remove rc shell to reduce FPs #4125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

theseion
Copy link
Contributor
@theseion theseion commented May 10, 2025

rc is a old Unix shell that we can consider obsolete.
A reimplementation with active Linux packages exists though, so we'll
still match at > PL 1

Fixes #4123

@theseion theseion requested a review from EsadCetiner May 10, 2025 06:24
Copy link
Contributor
github-actions bot commented May 10, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@theseion theseion force-pushed the remove-rc-shell branch 3 times, most recently from c23fe5d to 0683726 Compare May 10, 2025 06:28
Copy link
Member
@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to make sure it doesn't get added in the future?

8000
rc is a old Unix shell that we can consider obsolete.
A reimplementation with active Linux packages exists though, so we'll
still match at > PL 1

Fixes coreruleset#4123
@theseion theseion requested a review from EsadCetiner May 10, 2025 11:16
@theseion theseion added this pull request to the merge queue May 10, 2025
Merged via the queue into coreruleset:main with commit 13c83cd May 10, 2025
8 checks passed
@theseion theseion deleted the remove-rc-shell branch May 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive: "RC" value for rule 932250 (RCE)
3 participants
0