8000 Workaround missing ssl.PROTOCOL_TLS by fgsch · Pull Request #54 · coreruleset/ftw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Workaround missing ssl.PROTOCOL_TLS #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2020
Merged

Workaround missing ssl.PROTOCOL_TLS #54

merged 2 commits into from
Nov 20, 2020

Conversation

fgsch
Copy link
Contributor
@fgsch fgsch commented Nov 19, 2020

And bump in preparation for a new release.

fgsch added 2 commits November 19, 2020 23:08
@fgsch
Workaround missing ssl.PROTOCOL_TLS
ed4e761 
Some older python versions (e.g. 3.5.2) don't have it.
@fgsch
Bump version
43f663f
@fgsch fgsch requested a review from fzipi November 19, 2020 23:10
fzipi
fzipi approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, technically LGTM.

But... 2020.... do we need to support SSLv3? Don't get me wrong, I like to be inclusive.

I think you have additional tests not present here, right?

@fgsch
Copy link
Contributor Author
fgsch commented Nov 20, 2020 •
edited
Loading 
>>> import ssl
>>> ssl.PROTOCOL_TLS == ssl.PROTOCOL_SSLv23
True

PROTOCOL_SSLv23 is an alias for PROTOCOL_TLS in newer systems (> 2.7.12 and > 3.5.2).
Its usage is deprecated in favour of PROTOCOL_TLS.

@fgsch fgsch merged commit f5741aa into main Nov 20, 2020
@fgsch fgsch deleted the fgsch/python-workaround branch November 20, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgsch @fzipi
0