10000 Improved test support by theseion · Pull Request #70 · coreruleset/ftw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved test support #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2022
Merged

Improved test support #70

merged 3 commits into from
Mar 10, 2022

Conversation

theseion
Copy link
Contributor
@theseion theseion commented Mar 4, 2022 •
edited
Loading

Support creation of log markers.

Split from PR #66, part 3

@theseion theseion requested review from fgsch and fzipi March 4, 2022 08:08
@theseion theseion mentioned this pull request Mar 4, 2022
Closed
theseion added 2 commits March 10, 2022 20:15
@theseion
Added mark_start() and mark_end() to give the log checker the chance …
ca0a902 
…to pre and post process runs
@theseion
Improved test parameterization
b21f687 
Give log checker more information, so it can produce identifiable log markers
@theseion theseion force-pushed the performance-improvement-improved-test-support branch from c5c5f66 to bdfb4b7 Compare March 10, 2022 20:02
fzipi
fzipi approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member
@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you don't mind, I probably squash the last two commits for a cleaner history.

@fzipi
Copy link
Member
fzipi commented Mar 10, 2022

Oh, I can't do it using the GH interface. Can you squash those @theseion ?

@theseion
Copy link
Contributor Author

Damn, you're fast 😄. Sure, squash ahead.

@theseion
Copy link
Contributor Author

Apparently, I don't have write access to the repo, so no, I can't perform the merge / squash, sorry.

@fzipi
Copy link
Member
fzipi commented Mar 10, 2022

No, I mean you last two commits. The last one fbca174 can be squashed with bdfb4b7.

@theseion theseion force-pushed the performance-improvement-improved-test-support branch from fbca174 to 6ffa312 Compare March 10, 2022 20:22
@fzipi fzipi merged commit 8204a00 into coreruleset:main Mar 10, 2022
@theseion theseion deleted the performance-improvement-improved-test-support branch March 10, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@fgsch fgsch Awaiting requested review from fgsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @fzipi
0