Feature/config from string #364
Merged
+272
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `from_string/2` to parse kubeconfig YAML strings. - Provides dynamic configuration without relying on file paths. - Tests added for various scenarios, including invalid configurations. Fixes coryodaniel#202
|
Hi @mateuszkwiatkowski |
- Introduced `from_config/3` helper function to centralize code for parsing and creating connections from configurations. - Combined similar logic from `from_file/2` and `from_string/2` into `from_config/3`. - Unified certificate extraction with `cert_from_map/2` for both string and file paths. - Removed redundant functions: `cert_from_map_string_only/1` and `get_auth_string_only/1`.
|
@mruoss Good point! Please take a look again. |
|
Nice. Can you please rebase onto main (develop) and add an entry to CHANGELOG.md? |
|
@mruoss done! |
6947be5 to
14e49c7
Compare
14e49c7 to
d53f3bb
Compare
|
We hit the false positive in credo: rrrene/credo#1203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for kubeconfig YAML string in K8s.Conn
from_string/2to parse kubeconfig YAML strings.devcontainer: bump Elixir version 1.10 -> 1.14
Fixes #202