8000 Do not use FIPS and remove hardcode OPENSSL_VERSION_NUMBER with LibreSSL by cedk · Pull Request #599 · coturn/coturn · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not use FIPS and remove hardcode OPENSSL_VERSION_NUMBER with LibreSSL #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

Do not use FIPS and remove hardcode OPENSSL_VERSION_NUMBER with LibreSSL #599

merged 1 commit into from
Dec 8, 2020

Conversation

cedk
Copy link
Contributor
@cedk cedk commented Jul 19, 2020

Fix #552

@Neustradamus
Copy link

@misi: Have you seen?

@misi
Copy link
Contributor
misi commented Dec 7, 2020 •
edited
Loading

First of all accept my apologies for my late reply!
@cedk Do you think removing this default ssl version value will not cause any issue? I guess the reason it was there somehow to fallback if it is not configured. What do you think?

@cedk
Copy link
Contributor Author
cedk commented Dec 7, 2020

For me it prevents to use other feature of libressl to hard code its openssl version.
It is better to not use a feature based on the version of the library than pretending that a library has a different version.
As far as I have seen other codes use similar test when dealing with openssl and libressl compatibility.

@misi misi added this to the 4.5.2 milestone Dec 7, 2020
@misi
Copy link
Contributor
misi commented Dec 8, 2020

I am not expert on this field, so I hope it will not make any trouble.. :)
Thanks for your contribution!

@misi misi merged commit 00659f3 into coturn:master Dec 8, 2020
misi added a commit that referenced this pull request Dec 8, 2020
@misi
Add to changelog PR #655 #618 #599
b13cc41
@Neustradamus
Copy link

@misi: Thanks for merging of several PRs.

Please look other current PRs, last comments/changes and please do a new comment if it is not good...

@misi
Copy link
Contributor
misi commented Dec 8, 2020

@Neustradamus I do my best as always. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5.2
Development

Successfully merging this pull request may close these issues.

LibreSSL compilation failures
3 participants
@cedk @Neustradamus @misi
0